Merge pull request #48 from Charroja/master

Fix anti-pattern

server/cmd/preconfig_pos.go

@@ -15,7 +15,7 @@ func Preconfig(dkill bool) {
 		signal.Notify(sigc,
 			syscall.SIGHUP,
 			syscall.SIGINT,
-			syscall.SIGSTOP,
+
 			syscall.SIGPIPE,
 			syscall.SIGTERM,
 			syscall.SIGQUIT)

server/settings/db.go

@@ -4,8 +4,9 @@ import (
 	"path/filepath"
 	"strings"
 
-	bolt "go.etcd.io/bbolt"
 	"server/log"
+
+	bolt "go.etcd.io/bbolt"
 )
 
 type TDB struct {
@@ -99,7 +100,6 @@ func (v *TDB) Set(xpath, name string, value []byte) {
 		log.TLogln("value:", value)
 	}
 
-	return
 }
 
 func (v *TDB) List(xpath string) []string {
@@ -173,5 +173,4 @@ func (v *TDB) Rem(xpath, name string) {
 		log.TLogln("Error rem sets", xpath+"/"+name, ", error:", err)
 	}
 
-	return
 }

server/torr/storage/torrstor/cache.go

@@ -82,9 +82,7 @@ func (c *Cache) Piece(m metainfo.Piece) storage.PieceImpl {
 
 func (c *Cache) Close() error {
 	log.TLogln("Close cache for:", c.hash)
-	if _, ok := c.storage.caches[c.hash]; ok {
-		delete(c.storage.caches, c.hash)
-	}
+	delete(c.storage.caches, c.hash)
 	c.pieces = nil
 
 	c.muReaders.Lock()

server/torr/torrent.go

@@ -359,9 +359,7 @@ func (t *Torrent) Close() {
 	t.Stat = state.TorrentClosed
 
 	t.bt.mu.Lock()
-	if _, ok := t.bt.torrents[t.Hash()]; ok {
-		delete(t.bt.torrents, t.Hash())
-	}
+	delete(t.bt.torrents, t.Hash())
 	t.bt.mu.Unlock()
 
 	t.drop()

server/web/api/stream.go

@@ -211,5 +211,5 @@ func streamNoAuth(c *gin.Context) {
 	}
 	c.Header("WWW-Authenticate", "Basic realm=Authorization Required")
 	c.AbortWithStatus(http.StatusUnauthorized)
-	return
+
 }